chore: Lower giveup log level for retried functions to warning #26188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26188 +/- ##
==========================================
+ Coverage 69.15% 69.18% +0.03%
==========================================
Files 1944 1944
Lines 75925 75927 +2
Branches 8451 8451
==========================================
+ Hits 52505 52533 +28
+ Misses 21235 21209 -26
Partials 2185 2185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eschutho
reviewed
Dec 6, 2023
| @@ -26,13 +27,15 @@ def retry_call( | |||
| *args: Any, | |||
| strategy: Callable[..., Generator[int, None, None]] = backoff.constant, | |||
| exception: type[Exception] = Exception, | |||
| giveup_log_level: int = logging.WARNING, | |||
There was a problem hiding this comment.
I think just int is more precise here, since the default logging.WARNING is an int, and it wouldn't make sense to pass giveup_log_level=None
eschutho
approved these changes
Dec 6, 2023
michael-s-molina
added
the
v3.1
michael-s-molina
pushed a commit
that referenced
this pull request
Dec 8, 2023
(cherry picked from commit bf5b18c)
mistercrunch
added
🍒 3.1.0
🍒 3.1.1
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The goal of this PR is to eliminate unnecessary error logs. The
retry_callfunction uses thebackofflib to decorate functions we want to retry. After the retry limit is reached, thebackoffdecorator generates a log saying that it's giving up. This log defaults to the error level, which isn't necessary here since the exception raised by the wrapped function gets bubbled up and logged at the appropriate level already.This PR solves the issue by lowering the log from the
backoffdecorator to a warningBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION