-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Disables minor ticks by default #26310
chore: Disables minor ticks by default #26310
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26310 +/- ##
=======================================
Coverage 69.18% 69.18%
=======================================
Files 1945 1945
Lines 75967 75968 +1
Branches 8467 8467
=======================================
+ Hits 52556 52557 +1
Misses 21224 21224
Partials 2187 2187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One thing to keep in mind is minor ticks will now disappear from existing charts. However, I think this is ok, as long as we're in agreement that disabled minor ticks are a more sensible default.
(cherry picked from commit eb65cea)
(cherry picked from commit eb65cea)
(cherry picked from commit eb65cea)
SUMMARY
This PR follows the same standard defined by ECharts and disables minor ticks by default for ECharts charts. From a data visualization point of view, they only add visual noise/don’t facilitate reading the chart better for the majority of cases. For the specific cases where they might help with data interpretation, I added a new control that allows users to enable them. This will also help with consistency given that legacy charts also have minor ticks disabled by default.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
1 - Create a timeseries chart
2 - Check the new control behavior
3 - Check that charts are rendered without minor ticks by default
ADDITIONAL INFORMATION