fix(dashboard): Don't switch to first tab when directPathToChild changes #26340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26340 +/- ##
=======================================
Coverage 69.18% 69.18%
=======================================
Files 1945 1945
Lines 75971 75973 +2
Branches 8467 8468 +1
=======================================
+ Hits 52559 52561 +2
Misses 21225 21225
Partials 2187 2187
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/testenv up |
|
@kgabryje Container image not yet published for this PR. Please try again when build is complete. |
|
@kgabryje Ephemeral environment creation failed. Please check the Actions logs for details. |
michael-s-molina
added
v3.0
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
…ges (apache#26340) (cherry picked from commit 39ac453)
mistercrunch
added
🍒 3.0.3
🍒 3.0.4
🍒 3.1.0
🍒 3.1.1
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When user performed an action that caused
directPathToChildto point to an element outside ofDashboardContainer(such as clicking on applied native filter's name in chart's header to highlight the native filter), it caused the tabs to switch to the first tab.This PR fixes that behaviour to instead remain on current tab.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2023-12-22.at.11.47.24.mov
After:
Screen.Recording.2023-12-22.at.11.46.23.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION