fix: Removes non-existent columns in the 2018 FCC Survey dataset #26380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| params: null | ||
| template_params: null | ||
| filter_select_enabled: true | ||
| fetch_values_predicate: null | ||
| extra: null | ||
| uuid: d95a2865-53ce-1f82-a53d-8e3c89331469 | ||
| metrics: | ||
| - metric_name: count |
There was a problem hiding this comment.
Apart from formatting, the real changes are the removed columns.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26380 +/- ##
=======================================
Coverage 69.18% 69.18%
=======================================
Files 1946 1946
Lines 75988 75991 +3
Branches 8479 8479
=======================================
+ Hits 52570 52573 +3
Misses 21228 21228
Partials 2190 2190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
john-bodley
approved these changes
Dec 29, 2023
michael-s-molina
added
v3.0
sivasathyaseeelan
pushed a commit
to sivasathyaseeelan/superset
that referenced
this pull request
Jan 3, 2024
michael-s-molina
added a commit
that referenced
this pull request
Jan 4, 2024
) (cherry picked from commit 77f58fc)
michael-s-molina
added a commit
that referenced
this pull request
Jan 9, 2024
) (cherry picked from commit 77f58fc)
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
…che#26380) (cherry picked from commit 77f58fc)
mistercrunch
added
🍒 3.0.3
🍒 3.0.4
🍒 3.1.0
🍒 3.1.1
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The YAML definition for the FCC 2018 Survey dataset contains columns that don't exist in the physical table. This PR removes the following columns to avoid errors when viewing the data:
curr_employmentcurr_employment_otherrsrc_pluralsightFixes #25825
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
1 - Go to Datasets
2 - Select the FCC 2018 Survey dataset
3 - On Explore, select the Samples tab
4 - Check that the results are correctly displayed
ADDITIONAL INFORMATION