chore: Add Embed Modal extension override and tests #26759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26759 +/- ##
==========================================
+ Coverage 69.48% 69.53% +0.05%
==========================================
Files 1894 1894
Lines 74138 74655 +517
Branches 8243 8359 +116
==========================================
+ Hits 51514 51913 +399
- Misses 20555 20648 +93
- Partials 2069 2094 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kgabryje
approved these changes
Jan 23, 2024
superset-frontend/src/dashboard/components/EmbeddedModal/EmbeddedModal.test.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/EmbeddedModal/EmbeddedModal.test.tsx
Show resolved
Hide resolved
superset-frontend/src/dashboard/components/EmbeddedModal/EmbeddedModal.test.tsx
Show resolved
Hide resolved
|
Thanks for the PR and added tests @geido! I left some non-blocking comments that I think may help with readability and standardization. |
eschutho
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 31, 2024
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds an extension to override the whole Embed Modal.
Adds missing unit tests and moves the component to its own dir.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
CI should pass
ADDITIONAL INFORMATION