fix: docker should always run, even in forks #26801
Merged
+10
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realized that docker build should always runs, and simply not `--push` if we're not in `master` / don't have the creds. After this PR, docker will always run, though outside of the main fork, it won't push to docker hub.
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley and
kgabryje
as code owners
dpgaspar
approved these changes
Jan 25, 2024
rusackas
approved these changes
Jan 25, 2024
eschutho
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 31, 2024
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
the
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized that docker build should always runs, and simply not
--pushif we're not inmaster/ don't have the creds. The logic in the bash script already exists for that.After this PR, docker will always run, though outside of the main fork, it won't push to docker hub.
Testing
Using this PR, that is against the main fork, I validated that:
--pushto the repoUsing the sibling PR #26802 that is identical but against a fork, I validated that:
--load--cache-tois NOT set