feat(ci): add a check to make sure there's no hold label on the PR #26877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noticed on another PR (#26836) that we use `hold.*` labels, but they don't really hold the merge. After almost merging and realizing the hold after, I got GPT to generate the action here and tested it on that PR.
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
mistercrunch
added
hold:testing!
dpgaspar
approved these changes
Jan 30, 2024
.github/workflows/no-hold-label.yml
Outdated
| github-token: ${{secrets.GITHUB_TOKEN}} | ||
| script: | | ||
| const payload = context.payload.pull_request | ||
| const label = !!payload.labels.find(label => label.name.includes('hold')) |
There was a problem hiding this comment.
nit: const holdLabelPresent = payload.labels.some(label => label.name.startsWith('hold'));
eschutho
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 31, 2024
|
Nice! |
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed on another PR (#26836) that we use
hold.*labels, but they don't really hold the merge. After almost merging and realizing the hold after, I got GPT to generate the action here and tested it on that PR.Note that this will hold all PRs with any label containing the string
hold, which is what we need since we have multiple hold-related labels.