fix(maps): france_regions.geojson generated with the notebook, from natural earth data #27014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #26995, and to fix the countries_custom/france_regions.geojson added in #25676,
I propose to generate france_regions.geojson from the data provided department-wise by Natural Earth Data
but that can be merged together into their parent division, i.e. regions.
The geopandas dissolve function can do just that and the mapping departments=>regions comes from the ISO 3166-2 FR norm
SUMMARY
The previous france_regions.geojson ,while it was generated from a solid source (IGN BD TOPO), is large (12MB) compared to other files and provided in the incorrect projection (EPSG 2154 instead of EPSG 4326 / WGS 84), resulting in a buggy display in Superset while using the Country Map plugin.
All files from Natural Earth Data are provided with the EPSG 4326 / WSG 84 (source) and it is the projection understood by the Country Map plugin as its current implementation.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
In the notebook
In Superset
Most relevant bit of code in the notebook:
TESTING INSTRUCTIONS
Run the notebook to generate the new france_regions.geojson
ADDITIONAL INFORMATION