-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate AlteredSliceTag to typescript #27030
chore: Migrate AlteredSliceTag to typescript #27030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…github.com/EnxDev/superset into chore/typescript-migration-AlteredSliceTag
Co-authored-by: Geido <[email protected]>
Co-authored-by: Geido <[email protected]>
Co-authored-by: Geido <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27030 +/- ##
==========================================
- Coverage 67.31% 67.14% -0.17%
==========================================
Files 1895 1900 +5
Lines 74202 74397 +195
Branches 8219 8293 +74
==========================================
+ Hits 49949 49957 +8
- Misses 22204 22385 +181
- Partials 2049 2055 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a few final touches. I saw that you did not migrate the test file, however, I think that is the right choice considering that test should be converted to RTL and likely to rewritten.
Co-authored-by: Geido <[email protected]>
…github.com/EnxDev/superset into chore/typescript-migration-AlteredSliceTag
/testenv up |
@geido Ephemeral environment spinning up at http://34.219.235.255:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
Co-authored-by: geido <[email protected]> Co-authored-by: Geido <[email protected]>
Co-authored-by: geido <[email protected]> Co-authored-by: Geido <[email protected]>
SUMMARY
Migrate AlteredSliceTag to typescript
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION