-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SSH Tunnel configuration settings #27186
Conversation
…o/ch78628/fix-disabled-ssh-toggle
…o/ch78628/fix-disabled-ssh-toggle
…o/ch78628/fix-disabled-ssh-toggle
…o/ch78628/fix-disabled-ssh-toggle
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27186 +/- ##
==========================================
+ Coverage 67.34% 69.73% +2.38%
==========================================
Files 1909 1909
Lines 74623 74670 +47
Branches 8324 8324
==========================================
+ Hits 50255 52069 +1814
+ Misses 22314 20550 -1764
+ Partials 2054 2051 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…o/ch78628/fix-disabled-ssh-toggle
superset-frontend/src/features/databases/DatabaseModal/SSHTunnelSwitch.test.tsx
Show resolved
Hide resolved
superset-frontend/src/features/databases/DatabaseModal/SSHTunnelSwitch.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/features/databases/DatabaseModal/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few nonblocking comments but looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of non blocking comments
…o/ch78628/fix-disabled-ssh-toggle
@geido Ephemeral environment spinning up at http://35.89.241.113:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit 89e89de)
SUMMARY
This PR fixes several issues with the SSH Tunnel option in the Database Modal which are related to edit the SSH Tunnel config, enable/disable the option, and misc fixes/enhancements. In particular:
SSHTunnelSwitch
component from dynamic forms and merges the logics of both dynamic and SQLAlchemy forms into one overridable componentUpdateDatabaseCommand
SSH_TUNNELING
OFF. Saving would cause a "SSH Tunneling is not enabled" errorBEFORE
DEV.Superset.mp4
AFTER
DEV.Superset.1.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION