Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translations): Turkish translation files added #27244

Merged
merged 4 commits into from
Mar 5, 2024
Merged

feat(translations): Turkish translation files added #27244

merged 4 commits into from
Mar 5, 2024

Conversation

coteli
Copy link
Contributor

@coteli coteli commented Feb 25, 2024

SUMMARY

Turkish language translation files created and added. Many UI elements have been translated.

I noticed some mistakes in the pull request I opened earlier, number #27237. Therefore, to avoid complications, I closed that request and opened a new one after making the necessary corrections.

I apologize to those affected by the faulty pull request and thank them for their understanding.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

English Turkish

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the i18n Namespace | Anything related to localization label Feb 25, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (7353055) to head (01f6eaf).
Report is 1463 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27244      +/-   ##
==========================================
+ Coverage   67.37%   69.69%   +2.32%     
==========================================
  Files        1908     1908              
  Lines       74550    74523      -27     
  Branches     8317     8306      -11     
==========================================
+ Hits        50225    51937    +1712     
+ Misses      22272    20535    -1737     
+ Partials     2053     2051       -2     
Flag Coverage Δ
hive 53.78% <ø> (?)
mysql 78.00% <ø> (ø)
postgres 78.10% <ø> (ø)
presto 53.73% <ø> (?)
python 83.12% <ø> (+4.88%) ⬆️
sqlite 77.62% <ø> (ø)
unit 56.50% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas
Copy link
Member

rusackas commented Feb 26, 2024

@mistercrunch seems like the auto-labeler didn't find its config here, and didn't add all the i18n labels like it did on this PR's predecessor. Not sure if you happen to know why.

@geido
Copy link
Member

geido commented Feb 27, 2024

Hello @coteli thanks for the PR! CI needs a bit of love, some linting required.

@rusackas rusackas changed the title feat(translations):Turkish translation files added feat(translations): Turkish translation files added Feb 28, 2024
@rusackas
Copy link
Member

You can run the pre-commit hooks to fix the linting issues

@coteli
Copy link
Contributor Author

coteli commented Feb 28, 2024

You can run the pre-commit hooks to fix the linting issues

I run pre-commit hooks and all checks have passed. I hope it works, thanks for helping.
Ekran Resmi 2024-02-28 20 57 43

@geido
Copy link
Member

geido commented Feb 29, 2024

Hello @coteli there was a problem with a unit test on master that is affecting this PR. Please, pull fresh master and push back, it should solve the issue. Thank you

@coteli
Copy link
Contributor Author

coteli commented Mar 1, 2024

Hello @coteli there was a problem with a unit test on master that is affecting this PR. Please, pull fresh master and push back, it should solve the issue. Thank you

Hello @geido, thank you for your advice. I synced my branch with apache:master.

@rusackas
Copy link
Member

rusackas commented Mar 1, 2024

Thanks! Running CI 🤞

@geido
Copy link
Member

geido commented Mar 5, 2024

@rusackas this might need your stamp

@rusackas rusackas merged commit 69d870c into apache:master Mar 5, 2024
34 checks passed
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels i18n Namespace | Anything related to localization size/XXL 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants