Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): docker builds don't work from remote forks #27282

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix(ci): docker builds don't work from remote forks #27282

merged 1 commit into from
Feb 28, 2024

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Feb 28, 2024 •
edited
Loading

SUMMARY

Fix issues relate to multi-platform builds not working with --load.

Lots of intricacies around multi-platform builds somehow (doesn't work on OSx, doesn't work with --load, and somehow can't --push from remote forks, ...)

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Feb 28, 2024
michael-s-molina
michael-s-molina approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina mentioned this pull request Feb 28, 2024
Merged
9 tasks
@dpgaspar dpgaspar merged commit 0383bed into master Feb 28, 2024
23 of 24 checks passed
@rusackas rusackas deleted the fix_docker_again2 branch February 28, 2024 22:23
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch @sfirke
fix(ci): docker builds don't work from remote forks (apache#27282)
564578d
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@mistercrunch @qleroy
fix(ci): docker builds don't work from remote forks (apache#27282)
41c26cd
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch
fix(ci): docker builds don't work from remote forks (apache#27282)
5fb9f56
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@dpgaspar dpgaspar dpgaspar approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels github_actions Pull requests that update GitHub Actions code size/S 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @dpgaspar @michael-s-molina