-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Responsive UI for Big Number with Time Comparison #27375
Merged
kgabryje
merged 2 commits into
apache:master
from
kgabryje:feat/big-number-kpi-responsive
Mar 4, 2024
Merged
feat: Responsive UI for Big Number with Time Comparison #27375
kgabryje
merged 2 commits into
apache:master
from
kgabryje:feat/big-number-kpi-responsive
Mar 4, 2024
+138
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27375 +/- ##
==========================================
- Coverage 67.37% 67.35% -0.02%
==========================================
Files 1908 1909 +1
Lines 74550 74571 +21
Branches 8317 8321 +4
==========================================
Hits 50225 50225
- Misses 22272 22294 +22
+ Partials 2053 2052 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Antonio-RiveroMartnez
approved these changes
Mar 4, 2024
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 4, 2024
(cherry picked from commit 5de2530)
🏷️ preset:2024.8 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 4, 2024
(cherry picked from commit 5de2530)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 7, 2024
(cherry picked from commit 5de2530)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 8, 2024
(cherry picked from commit 5de2530)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 14, 2024
(cherry picked from commit 5de2530)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 19, 2024
(cherry picked from commit 5de2530)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 22, 2024
(cherry picked from commit 5de2530)
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 26, 2024
(cherry picked from commit 5de2530)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 26, 2024
(cherry picked from commit 5de2530)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 28, 2024
(cherry picked from commit 5de2530)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 1, 2024
(cherry picked from commit 5de2530)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 2, 2024
(cherry picked from commit 5de2530)
betodealmeida
pushed a commit
that referenced
this pull request
Apr 25, 2024
(cherry picked from commit 5de2530)
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
eschutho
pushed a commit
that referenced
this pull request
Jun 5, 2024
(cherry picked from commit 5de2530)
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 4.1.0
labels
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the Big Number with Time Comparison is rendered only horizontally and is not responsive in small containers. This PR refactors a lot of styles of the chart (table display -> flex) and implements a ResizeObserver which controls the flex direction - row for wide containers and column for narrow containers.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2024-03-02.at.17.31.55.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION