Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql_parse): Ensure table extraction handles Jinja templating #27470

Merged

fix(sql_parse): Ensure table extraction handles Jinja templating

9780350
Select commit
Loading
Failed to load commit list.
Merged

fix(sql_parse): Ensure table extraction handles Jinja templating #27470

fix(sql_parse): Ensure table extraction handles Jinja templating
9780350
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 21, 2024 in 0s

69.82% (+2.35%) compared to f274c47

View this Pull Request on Codecov

69.82% (+2.35%) compared to f274c47

Details

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 69.82%. Comparing base (f274c47) to head (9780350).
Report is 2 commits behind head on master.

Files Patch % Lines
superset/models/sql_lab.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27470      +/-   ##
==========================================
+ Coverage   67.46%   69.82%   +2.35%     
==========================================
  Files        1910     1910              
  Lines       74802    74815      +13     
  Branches     8345     8345              
==========================================
+ Hits        50467    52236    +1769     
+ Misses      22284    20528    -1756     
  Partials     2051     2051              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.