Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts-reports): adding pdf filetype to email and slack reports #27497

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

fisjac
Copy link
Contributor

@fisjac fisjac commented Mar 13, 2024

SUMMARY

Adding requested pdf filetype to options for alerts and reports

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
https://www.loom.com/share/accb313d566e413d9ee572a5da86f07c

After:
https://www.loom.com/share/7e52e6e95d094f6192cb84dea3d2a4f9

TESTING INSTRUCTIONS

Create an alert or report a dashboard or chart. Select the pdf option under content format. Save the report and activate it. The report should send as a pdf.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: ALERT_REPORTS=True
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 58.46154% with 27 lines in your changes missing coverage. Please review.

Project coverage is 69.72%. Comparing base (a75bb76) to head (8328bf0).
Report is 1424 commits behind head on master.

Files with missing lines Patch % Lines
superset/utils/pdf.py 30.43% 16 Missing ⚠️
superset/commands/report/execute.py 50.00% 6 Missing ⚠️
...-frontend/src/features/alerts/AlertReportModal.tsx 77.77% 1 Missing and 1 partial ⚠️
superset/reports/notifications/email.py 80.00% 1 Missing ⚠️
superset/reports/notifications/slack.py 85.71% 1 Missing ⚠️
superset/utils/core.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27497      +/-   ##
==========================================
+ Coverage   67.37%   69.72%   +2.34%     
==========================================
  Files        1909     1910       +1     
  Lines       74694    74736      +42     
  Branches     8326     8324       -2     
==========================================
+ Hits        50323    52107    +1784     
+ Misses      22321    20580    -1741     
+ Partials     2050     2049       -1     
Flag Coverage Δ
hive 53.68% <32.14%> (?)
javascript 57.22% <77.77%> (+<0.01%) ⬆️
mysql 77.97% <55.35%> (-0.02%) ⬇️
postgres 78.07% <55.35%> (-0.05%) ⬇️
presto 53.63% <32.14%> (?)
python 83.10% <55.35%> (+4.84%) ⬆️
sqlite 77.52% <55.35%> (-0.05%) ⬇️
unit 56.58% <26.78%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fisjac, this looks really great! LGTM!

@geido geido merged commit 30b497e into apache:master Mar 22, 2024
39 checks passed
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 26, 2024
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 26, 2024
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 26, 2024
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 28, 2024
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Apr 1, 2024
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Apr 2, 2024
@Shah-Panam
Copy link

In which version will this feature be available?

@eschutho
Copy link
Member

@Shah-Panam This feature will go into the 4.1 release in/around May.

@Shah-Panam
Copy link

@eschutho Thanks for letting me know.

betodealmeida pushed a commit that referenced this pull request Apr 25, 2024
eschutho pushed a commit that referenced this pull request Jun 5, 2024
@sfirke sfirke mentioned this pull request Jul 19, 2024
9 tasks
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants