-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerts-reports): adding pdf filetype to email and slack reports #27497
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27497 +/- ##
==========================================
+ Coverage 67.37% 69.72% +2.34%
==========================================
Files 1909 1910 +1
Lines 74694 74736 +42
Branches 8326 8324 -2
==========================================
+ Hits 50323 52107 +1784
+ Misses 22321 20580 -1741
+ Partials 2050 2049 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cbd4cd8
to
8328bf0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fisjac, this looks really great! LGTM!
…pache#27497) (cherry picked from commit 30b497e)
…pache#27497) (cherry picked from commit 30b497e)
…pache#27497) (cherry picked from commit 30b497e)
…pache#27497) (cherry picked from commit 30b497e)
…pache#27497) (cherry picked from commit 30b497e)
…pache#27497) (cherry picked from commit 30b497e)
In which version will this feature be available? |
@Shah-Panam This feature will go into the 4.1 release in/around May. |
@eschutho Thanks for letting me know. |
SUMMARY
Adding requested pdf filetype to options for alerts and reports
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://www.loom.com/share/accb313d566e413d9ee572a5da86f07c
After:
https://www.loom.com/share/7e52e6e95d094f6192cb84dea3d2a4f9
TESTING INSTRUCTIONS
Create an alert or report a dashboard or chart. Select the pdf option under content format. Save the report and activate it. The report should send as a pdf.
ADDITIONAL INFORMATION