Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update required jobs in .asf.yml #27574

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Mar 19, 2024

SUMMARY

This PR adds various required GitHub workflow to the ASF configuration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Regrettably this is hard to test as the changes—we postulate—need to be merged to master in order for the settings to be applied to the repo.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley changed the title chore: Update required jobs in asf.yml chore: Update required jobs in .asf.yml Mar 19, 2024
@john-bodley john-bodley merged commit ad7bd09 into master Mar 19, 2024
35 of 37 checks passed
@john-bodley john-bodley deleted the john-bodley--chore-asf-required-jobs branch March 19, 2024 18:09
@mistercrunch
Copy link
Member

mistercrunch commented Mar 20, 2024

@john-bodley hey since these workflows are conditional (they only run if a file in superset/** is touched) they need an entry in .github/workflows/no-op.yml which create a dummy successful task in case the task is avoided. I added entries that file in this PR #27571 so I could merge it. I think it takes care of things, but people will have to rebase to get those no-op to run.

I wish there was a better way to say "this workflow is required but only if/when it's triggered". The no-op approach is the best workaround I found when I researched it a little while back.

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@john-bodley john-bodley mentioned this pull request Mar 27, 2024
9 tasks
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants