-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Removes filter plugins from viz gallery #27763
fix: Removes filter plugins from viz gallery #27763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27763 +/- ##
==========================================
+ Coverage 69.78% 69.79% +0.01%
==========================================
Files 1911 1913 +2
Lines 75024 75109 +85
Branches 8355 8393 +38
==========================================
+ Hits 52352 52419 +67
- Misses 20622 20626 +4
- Partials 2050 2064 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SUMMARY
This PR creates a enum to register the filter plugins and use that enum to remove this type of plugin from the viz gallery.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Check that filter plugins are not displayed in the viz gallery
ADDITIONAL INFORMATION