Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Locale sent to frontend #27926

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: Locale sent to frontend #27926

merged 1 commit into from
Apr 8, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes a bug where the locale was sent to the frontend as an unserializable flask babel object instead of the expected language string.

Fixes #27881

TESTING INSTRUCTIONS

CI should be sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina merged commit 996cced into apache:master Apr 8, 2024
41 of 42 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Apr 11, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 15, 2024
@michael-s-molina @EnxDev
fix: Locale sent to frontend (apache#27926)
1550fc1
michael-s-molina added a commit that referenced this pull request Apr 16, 2024
@michael-s-molina
fix: Locale sent to frontend (#27926)
e6ff82f 
(cherry picked from commit 996cced)
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@michael-s-molina @qleroy
fix: Locale sent to frontend (apache#27926)
43968da
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@michael-s-molina @jzhao62
fix: Locale sent to frontend (apache#27926)
793e8df
@mistercrunch mistercrunch added 🍒 4.0.1 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@michael-s-molina
fix: Locale sent to frontend (apache#27926)
1b28bde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

@dpgaspar dpgaspar Awaiting requested review from dpgaspar

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.1 🍒 4.0.2 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Locale object/string mixup
3 participants
@michael-s-molina @john-bodley @mistercrunch