feat(country-map): Adds Philippines regional map and updates/cleans existing Philippines provincial map #27933
Conversation
- Removes inconsistently placed highly urbanized cities (HUCs) and merges them into their respective geographical province. - Merges all 16 HUC and 1 municipality in the Metropolitan Manila area under "Manila" with the pseudo ISO-3166-2 code of "PH-MNL" - Adds missing provinces: Davao Occidental, Dinagat Islands - Updates outdated provincial name: Compostella Valley -> Davao de Oro
Regional subdivisions of the Philippines, including their name and ISO-3166-2:PH code
Renames 'Manila' to 'Metro Manila'. Additional cleanings.
Cleans 'National Capital Region'
Changes to Metro Manila
Changes to Manila and Rizal
Cleans CALABARZON provinces
Cleans Region 3
Cleans Regions I, II, III, and CAR
Cleans regions I, II, III, and CAR
Cleans regions I, II, III, and CAR
Cleans Bicol Region
Cleans region 6 and 7
Cleans region 9 and 10
Splits Maguindanao into Maguindanao del Norte and del Sur
Cleans the rest of Mindanao
Fixes Surigao del Norte
Cleans Luzon regions
Fixes Cordillera Administrative Region
Cleans Visayas regions
Fixes Leyte
Fixes Mindanao regions
Further cleanings
Merges subdivisions within a region
Actually merges the subdivisions within regions
Changes the ISO code for Metro Manila from a pseudo provincial ISO code of `PH-MNL` to its regional ISO code `PH-00`
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Hi there... this is great, and we thank you for the contribution. Both the geojson files and the countries.ts file in this PR will be overwritten by anyone running the Jupyter notebook that generates Superset's maps. Would you be able to make your changes in that notebook so that the geojson/typescript in this PR is generated? This will help the whole project maintain good maps going forward. |
coordinates from jupyter notebook
Fixes outdated names of BARMM and Caraga
|
Added it. I hope it's okay that I used a different source for the changes that I made for the |
|
I'll take a look... as long as the data being pulled in is license-compatible with the Apache 2 license, I think we should be OK. |
|
I see the repo you set up with the geojson is MIT licensed. I suppose that's good enough, though I don't know where it came from beyond that 🤔 . Meanwhile, I'll close and reopen this to see if we can get CI to finish this time. |
|
Some of the coordinates are still from the original .geojson file that was generated by the notebook. The rest are hand-fixed using geojson.io. And according to them:
|
…xisting Philippines provincial map (apache#27933)
…xisting Philippines provincial map (apache#27933)
…xisting Philippines provincial map (apache#27933)
mistercrunch
added
🏷️ bot
SUMMARY
philippines_regions.geojsonmap using the regional ISO codesphilippines.geojsonby dividing Maguindanao province to Maguindanao del Norte and Maguindanao del Sur, as well as splintering off Davao Occidental from Davao del Surphilippines.geojsonby incorporating the inconsistently placed highly urbanized cities (which sometimes uses a pseudo-ISO code) into their respective geographical provinces. This is done to be more in line with how the Philippine Statistics Authority does it in their census.PH-00since there is no provincial ISO for the cities within.References:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION