-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explore): Color scheme groups, new color schemes #27995
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
fc4d856
adjust Select to support OptGroup
kgabryje f22ff96
Add new color schemes, update groups, add tests
kgabryje e3da8ae
fixes
kgabryje 92c401a
Use antd select
kgabryje 7d40b6f
add search
kgabryje 68c2dbb
Fix search
kgabryje bbdbbf2
Fix tests
kgabryje 89b3bfa
Remove OptGroup references
kgabryje a5fce67
Address comments
kgabryje File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
...rset-frontend/packages/superset-ui-core/src/color/colorSchemes/categorical/blueToGreen.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import CategoricalScheme from '../../CategoricalScheme'; | ||
import { ColorSchemeGroup } from '../../types'; | ||
|
||
const schemes = [ | ||
{ | ||
id: 'blueToGreen', | ||
label: 'Blue to green', | ||
group: ColorSchemeGroup.Featured, | ||
colors: [ | ||
'#3200A7', | ||
'#004CDA', | ||
'#0074F1', | ||
'#0096EF', | ||
'#53BFFF', | ||
'#41C8E6', | ||
'#30DEDE', | ||
'#04D9C7', | ||
'#00EAA2', | ||
'#A6FF93', | ||
], | ||
}, | ||
].map(s => new CategoricalScheme(s)); | ||
|
||
export default schemes; |
45 changes: 45 additions & 0 deletions
45
...-frontend/packages/superset-ui-core/src/color/colorSchemes/categorical/colorsOfRainbow.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import CategoricalScheme from '../../CategoricalScheme'; | ||
import { ColorSchemeGroup } from '../../types'; | ||
|
||
const schemes = [ | ||
{ | ||
id: 'colorsOfRainbow', | ||
label: 'Colors of rainbow', | ||
group: ColorSchemeGroup.Featured, | ||
colors: [ | ||
'#41ED86', | ||
'#2FC096', | ||
'#01DFFF', | ||
'#153AE0', | ||
'#850AD6', | ||
'#BD59FF', | ||
'#FF4A96', | ||
'#C32668', | ||
'#F40000', | ||
'#FF8901', | ||
'#FFBC0A', | ||
'#FFEC43', | ||
], | ||
}, | ||
].map(s => new CategoricalScheme(s)); | ||
|
||
export default schemes; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
...set-frontend/packages/superset-ui-core/src/color/colorSchemes/categorical/modernSunset.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import CategoricalScheme from '../../CategoricalScheme'; | ||
import { ColorSchemeGroup } from '../../types'; | ||
|
||
const schemes = [ | ||
{ | ||
id: 'modernSunset', | ||
label: 'Modern sunset', | ||
group: ColorSchemeGroup.Featured, | ||
colors: [ | ||
'#0080F6', | ||
'#254081', | ||
'#6C4592', | ||
'#A94693', | ||
'#DC4180', | ||
'#F35193', | ||
'#FF7582', | ||
'#FF4C5D', | ||
'#FF824E', | ||
'#FFAD2A', | ||
'#FFDB04', | ||
'#F3F700', | ||
], | ||
}, | ||
].map(s => new CategoricalScheme(s)); | ||
|
||
export default schemes; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
...rontend/packages/superset-ui-core/src/color/colorSchemes/categorical/presetAndSuperset.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import CategoricalScheme from '../../CategoricalScheme'; | ||
import { ColorSchemeGroup } from '../../types'; | ||
|
||
const schemes = [ | ||
{ | ||
id: 'supersetAndPresetColors', | ||
label: 'Preset + Superset', | ||
group: ColorSchemeGroup.Featured, | ||
colors: [ | ||
'#004960', | ||
'#2893B3', | ||
'#20A7C9', | ||
'#5CC0DA', | ||
'#7DCDE1', | ||
'#A9D3E1', | ||
'#C6ECE1', | ||
'#AAE2D2', | ||
'#71CFB4', | ||
'#2FC096', | ||
'#178F7A', | ||
'#067162', | ||
], | ||
}, | ||
].map(s => new CategoricalScheme(s)); | ||
|
||
export default schemes; |
43 changes: 43 additions & 0 deletions
43
...rset-frontend/packages/superset-ui-core/src/color/colorSchemes/categorical/redToYellow.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import CategoricalScheme from '../../CategoricalScheme'; | ||
import { ColorSchemeGroup } from '../../types'; | ||
|
||
const schemes = [ | ||
{ | ||
id: 'redToYellow', | ||
label: 'Red to yellow', | ||
group: ColorSchemeGroup.Featured, | ||
colors: [ | ||
'#90042A', | ||
'#D60039', | ||
'#D1353B', | ||
'#E45233', | ||
'#F47028', | ||
'#FE8E17', | ||
'#FFAD00', | ||
'#FFCC00', | ||
'#FFE601', | ||
'#FFF46D', | ||
], | ||
}, | ||
].map(s => new CategoricalScheme(s)); | ||
|
||
export default schemes; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if these should go into the
theme
object. Could you add aTODO
comment to revisit this file when working on SIP-82 Improving Superset Theming?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think all the other colour scheme files (including the old ones) should be revisited? I can add todos to all of them so that we don't miss them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be great! Thank you!