Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: db migrations on downgrade #28106

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: db migrations on downgrade #28106

merged 1 commit into from
Apr 17, 2024

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Apr 17, 2024 •
edited
Loading

SUMMARY

Currently when downgrading migrations we get the following error:

INFO  [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO  [alembic.runtime.migration] Will assume transactional DDL.
ERROR [flask_migrate] Error: Ambiguous walk

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar requested a review from a team as a code owner April 17, 2024 15:04
@github-actions github-actions bot added the risk:db-migration PRs that require a DB migration label Apr 17, 2024
@dpgaspar dpgaspar merged commit 5ece57b into apache:master Apr 17, 2024
33 of 37 checks passed
@dpgaspar dpgaspar deleted the fix/migrations-v1 branch April 17, 2024 15:37
@mistercrunch
Copy link
Member

I think I generated those, my bad. Guessing the alembic merge isn't the right way to go (?) I'll try and line up my migrations in the future.

Should we add a unit GHA that tests the downgrade?

@dpgaspar
Copy link
Member Author

I think I generated those, my bad. Guessing the alembic merge isn't the right way to go (?) I'll try and line up my migrations in the future.

Should we add a unit GHA that tests the downgrade?

no problem! a downgrade test sounds good to me

qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@dpgaspar @qleroy
fix: db migrations on downgrade (apache#28106)
5571819
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@dpgaspar @jzhao62
fix: db migrations on downgrade (apache#28106)
1be1ffa
pepperblue pushed a commit to pepperblue/superset that referenced this pull request Aug 7, 2024
Revert "fix: db migrations on downgrade (apache#28106)"
42e8e6c 
This reverts commit 5ece57b.
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@dpgaspar
fix: db migrations on downgrade (apache#28106)
3e85a58
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:db-migration PRs that require a DB migration size/M 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgaspar @mistercrunch @craig-rueda