Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Dashboard): Improve accessibility chart descriptions #28127

Merged
merged 1 commit into from
Apr 18, 2024
Merged

chore(Dashboard): Improve accessibility chart descriptions #28127

merged 1 commit into from
Apr 18, 2024

Conversation

geido
Copy link
Member

@geido geido commented Apr 18, 2024

SUMMARY

Improve the accessibility of chart descriptions by adding the appropriate roles and ARIA properties.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

  1. Visit the Dashboard with a screen reader
  2. Make sure that the chart description is accessible

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido changed the title chore(Dashboard) Improve accessibility chart descriptions chore(Dashboard): Improve accessibility chart descriptions Apr 18, 2024
@geido geido requested a review from kgabryje April 18, 2024 15:34
@geido geido merged commit 9ee56bb into master Apr 18, 2024
31 of 33 checks passed
@john-bodley john-bodley added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Apr 18, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@geido @qleroy
chore(Dashboard): Improve accessibility chart descriptions (apache#28127
5647b75 
)
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@geido @jzhao62
chore(Dashboard): Improve accessibility chart descriptions (apache#28127
b19ced9 
)
eschutho pushed a commit that referenced this pull request Jun 5, 2024
@geido @sadpandajoe
chore(Dashboard): Improve accessibility chart descriptions (#28127)
7e869cb 
(cherry picked from commit 9ee56bb)
@rusackas rusackas deleted the geido/chore/accessibility-dashboard-charts-desc branch September 27, 2024 21:04
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@geido
chore(Dashboard): Improve accessibility chart descriptions (apache#28127
3709623 
)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geido @kgabryje @mistercrunch @john-bodley