Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(translations): add Arabic translations stub #28129

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

OmarIthawi
Copy link
Contributor

@OmarIthawi OmarIthawi commented Apr 18, 2024

SUMMARY

Generate the Arabic file and add few Arabic translations so translators can start translating.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • TODO

TESTING INSTRUCTIONS

  • TODO

Related issue

@github-actions github-actions bot added the i18n Namespace | Anything related to localization label Apr 18, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@rusackas
Copy link
Member

Looks fine to me so far. Did you want to do any translations on this PR, or are you planning to follow up on separate ones?

@OmarIthawi
Copy link
Contributor Author

Looks fine to me so far.

Thanks @rusackas for the review.

Did you want to do any translations on this PR,

No, I've added some translations. I'm not planning to add more in this pull request.

or are you planning to follow up on separate ones?

Yes. I'll pass to our translation team and we'll get back in the future with other pull requests.

Generate the Arabic file and add few Arabic translations
so translators can start translating.
@rusackas rusackas merged commit cddcff2 into apache:master Apr 22, 2024
28 checks passed
@OmarIthawi
Copy link
Contributor Author

Thanks @rusackas for triaging this pull request!

qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels i18n Namespace | Anything related to localization size/XXL 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants