-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump sqlparse to 0.5.0 #28144
fix: bump sqlparse to 0.5.0 #28144
Conversation
@dpgaspar and @betodealmeida is the plan sitll—per [SIP-117] Improve SQL parsing —to remove |
pyproject.toml
Outdated
@@ -89,7 +89,7 @@ dependencies = [ | |||
"sqlalchemy>=1.4, <2", | |||
"sqlalchemy-utils>=0.38.3, <0.39", | |||
"sqlglot>=23.0.2,<24", | |||
"sqlparse>=0.4.4, <0.5", | |||
"sqlparse>=0.4.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for a noob question, but should this be sqlparse>=0.5.0
, to preclude people from using anything less?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not noob, I think it makes sense
Yes, I'm still working on it. Had to put aside to work on catalogs (SIP-95), but I'm going to finish the work on SIP-117 soon. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28144 +/- ##
===========================================
+ Coverage 60.48% 83.40% +22.92%
===========================================
Files 1931 521 -1410
Lines 76236 37467 -38769
Branches 8568 0 -8568
===========================================
- Hits 46114 31251 -14863
+ Misses 28017 6216 -21801
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CVE-2024-4340 is reported as Will this version bump be applied to the 3.1-x branch too to avoid that CVE affecting current stable versions? |
SUMMARY
Bumps sqlparse to 0.5.0 to address a potencial vulnerability.
Followup from: #28042
Don't think we will have breaking changes here, I think that our upper bound was a cautions bound following semantic versioning for 0.X.X versions.
Changelog: https://github.com/andialbrecht/sqlparse/blob/master/CHANGELOG
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION