chore(applitools): making tests more static for consistent testing #28201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@geido I never got around to doing more of this Applitools stabilization. Should we just merge this one, and eventually open more like it? |
john-bodley
reviewed
May 8, 2024
| @@ -593,19 +593,19 @@ const shoppingData: ShoppingData[] = [ | |||
| { | |||
| key: 1, | |||
| item: 'Floppy Disk 10 pack', | |||
| orderDate: Date.now(), | |||
| orderDate: new Date('2015-07-02T16:16:00Z').getTime(), | |||
There was a problem hiding this comment.
Is there something akin to freezegun for frontend code?
There was a problem hiding this comment.
Good question! I'll try to remember to look into it, but I'm not sure of one offhand. I just picked the timestamp of Superset's first commit since it's pretty arbitrary here. ¯\_(ツ)_/¯
|
@justinpark @michael-s-molina might as well merge this thing if you don't see any reason not to. It fixes up the appltools stability of just one test. I thought I'd go deeper and grow the PR, but just haven't had time to. |
geido
approved these changes
Jun 20, 2024
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Applitools is throwing visual regression errors because of things like Date.now()... this branch will serve as a place to start locking these things down as static, so our tests will be more meaningful than ignoring these zones in countless places.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION