Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Move ::: onto its own line to fix caution formatting #28243

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

sfirke
Copy link
Member

@sfirke sfirke commented Apr 26, 2024

SUMMARY

Tried to fix this in #28236, it didn't work, trying again. I'm modeling the fix on the caution block on the page https://raw.githubusercontent.com/apache/superset/master/docs/docs/quickstart.mdx which renders correctly.

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Apr 26, 2024
@sfirke sfirke requested a review from rusackas April 26, 2024 23:49
@mistercrunch
Copy link
Member

Do you run yarn run start? It works super well for me and updates the pages instantly as I save files.

@sfirke
Copy link
Member Author

sfirke commented Apr 27, 2024

I haven't - sounds like I should, thanks for the tip! My current dev setup leaves a lot to be desired, I need to improve it...

@sfirke sfirke merged commit fca3a52 into master Apr 27, 2024
31 of 32 checks passed
@sfirke sfirke deleted the fix-caution-formatting-error branch April 27, 2024 00:02
@mistercrunch
Copy link
Member

Oh yeah it's super neat - starts a process that monitors and auto-refreshes, you don't even need to cmd-r to refresh the page, otherwise you're flying blind!

@rusackas
Copy link
Member

Just "yarn start" to be pedantic ;)

qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels doc Namespace | Anything related to documentation size/XS 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants