-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix master build by merging alembic migration heads #28361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
BTW @mistercrunch #28361 was just merged today and we could likely just change the revision keys in the associated migration file if we didn't want to add another migration. |
@mistercrunch I wonder if there could be a GitHub action—something which I'm not overly well versed with—that could enforce that any PR which touches a migration file must be rebased against |
I think there's a timing issue here where while things may be ok at the time the PR is updated (and CI runs), it doesn't mean things are ok after when the main branch has changed. We'd need something like pre-merge hook but I don't think they exist. |
One approach would be to try and "auto-fix" with a script that would run when That or maybe merge queues? https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue |
See title, this happens when merging two database migration without rebasing first
ERROR