Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): improved Russian translation #28371

Closed
wants to merge 0 commits into from
Closed

Conversation

goldjee
Copy link
Contributor

@goldjee goldjee commented May 7, 2024

SUMMARY

This is a pretty big change to Russian translation.

  • Extracted new strings and updated language files, as described in the documentation.
  • Normalized usage of dots at the end of sentences. The rule is simple: if given label contains only one sentence, it should not be ended with a dot. On the contrary, labels comprised of several sentences should be ended with a dot.
  • Normalized usage of "е" and "ё" symbols. As there was no "ё" pretty much everywhere and people are used to omit dots above this symbol, I have changed "ё" to "е" everywhere this symbol occurs.
  • Fixed typos and written language style issues.
  • Renamed chart to "Диаграмма" (previously it was called "График"). The reason is that "график" is a word that means "line plot". As most of visuals types are not plots, it is much more correct to call them "диаграмма" (diagram, chart) instead.
  • Normalized naming of various chart types.
  • Used English names for things where it is appropriate. For instance, "Superset" should not be translated to "Суперсет", as it is a proper noun.
  • Added quite a bunch of missing strings, corrected and confirmed some drafts.
  • Shortened some strings for the sake of brevity and to make them fit into tight spaces.

Of course, there is still a lot of work to do, but I have managed to cover the most frequently viewed UI elements and pages. Hope the team and end users will find this version alright.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@goldjee goldjee requested review from villebro and rusackas as code owners May 7, 2024 15:01
@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:spanish Translation related to Spanish language i18n:italian Translation related to Italian language i18n:french Translation related to French language i18n:chinese Translation related to Chinese language i18n:japanese Translation related to Japanese language i18n:russian Translation related to Russian language i18n:korean Translation related to Korean language i18n:dutch i18n:slovak i18n:ukrainian i18n:portuguese i18n:brazilian i18n:traditional-chinese and removed size/XXL labels May 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.21%. Comparing base (2e5f3ed) to head (12215d8).
Report is 43 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #28371       +/-   ##
===========================================
+ Coverage   60.49%   83.21%   +22.71%     
===========================================
  Files        1931      521     -1410     
  Lines       76241    37184    -39057     
  Branches     8566        0     -8566     
===========================================
- Hits        46122    30942    -15180     
+ Misses      28015     6242    -21773     
+ Partials     2104        0     -2104     
Flag Coverage Δ
hive 49.10% <ø> (-0.06%) ⬇️
javascript ?
mysql 77.22% <ø> (?)
postgres 77.35% <ø> (?)
presto 53.70% <ø> (-0.10%) ⬇️
python 83.21% <ø> (+19.72%) ⬆️
sqlite 76.80% <ø> (?)
unit 58.29% <ø> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley requested review from kgabryje and removed request for kgabryje May 7, 2024 17:37
@goldjee
Copy link
Contributor Author

goldjee commented May 14, 2024

@villebro @rusackas @john-bodley do you have any plans on merging this?

@rusackas
Copy link
Member

I would love to! We need to contend with a few things, however:

  • It seems like the ASF license was removed from the .pot file (maybe it was replaced instead of being edited? I'm not sure what did this)
  • It looks like there are some linting issues that can probably be resolved by the pre-commit hook: https://superset.apache.org/docs/contributing/development/#git-hooks
  • This isn't your fault, but I don't know what to do yet... clearly you only touched one language, but ALL the language files are re-ordered somewhat randomly. We have a few translation PRs doing this, which means we're probably going to have conflict nightmares until we find a way to get these .pot/.po/.json files to be rendered more deterministically. Not sure if @villebro happens to know anything about this... it's on my investigation list, and I swear I saw a PR claiming to fix this get merged not so long ago.

@goldjee
Copy link
Contributor Author

goldjee commented May 14, 2024

Thank you for your feedback!

I'm not sure how the license header in .pot file got altered as I haven't touched the file manually. In order to fix that, I have ran

pre-commit run --all-files
./scripts/babel_update.sh
./scripts/po2json.sh

Seems that the ASF license header is back and the branch now passes pre-commit checks. I hope it's good now.

Regarding .po rearrangement, yeah, I can see it happens after running babel_update.sh and affects all the language files. The content was shuffled despite I haven't pulled any updates from the upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n:brazilian i18n:chinese Translation related to Chinese language i18n:dutch i18n:french Translation related to French language i18n:italian Translation related to Italian language i18n:japanese Translation related to Japanese language i18n:korean Translation related to Korean language i18n:portuguese i18n:russian Translation related to Russian language i18n:slovak i18n:spanish Translation related to Spanish language i18n:traditional-chinese i18n:ukrainian i18n Namespace | Anything related to localization size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants