-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(i18n): improved Russian translation #28371
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28371 +/- ##
===========================================
+ Coverage 60.49% 83.21% +22.71%
===========================================
Files 1931 521 -1410
Lines 76241 37184 -39057
Branches 8566 0 -8566
===========================================
- Hits 46122 30942 -15180
+ Misses 28015 6242 -21773
+ Partials 2104 0 -2104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@villebro @rusackas @john-bodley do you have any plans on merging this? |
I would love to! We need to contend with a few things, however:
|
Thank you for your feedback! I'm not sure how the license header in .pot file got altered as I haven't touched the file manually. In order to fix that, I have ran
Seems that the ASF license header is back and the branch now passes pre-commit checks. I hope it's good now. Regarding .po rearrangement, yeah, I can see it happens after running babel_update.sh and affects all the language files. The content was shuffled despite I haven't pulled any updates from the upstream. |
SUMMARY
This is a pretty big change to Russian translation.
Of course, there is still a lot of work to do, but I have managed to cover the most frequently viewed UI elements and pages. Hope the team and end users will find this version alright.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION