feat(SIP-95): catalogs in SQL Lab and datasets #28376
Merged
+841
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
catalog-sqllab
branch
from
b8fc10d to
073767f
Compare
betodealmeida
force-pushed
the
catalog-sqllab
branch
from
aa3182e to
65689a6
Compare
betodealmeida
force-pushed
the
catalog-sqllab
branch
from
65689a6 to
0075484
Compare
eschutho
reviewed
May 8, 2024
| @@ -410,6 +412,8 @@ export default function sqlLabReducer(state = {}, action) { | |||
| return state; | |||
| }, | |||
| [actions.LOAD_QUERY_EDITOR]() { | |||
| console.log(state); | |||
| console.log(state.unsavedQueryEditor); | |||
There was a problem hiding this comment.
Suggested change
| console.log(state.unsavedQueryEditor); |
eschutho
reviewed
May 8, 2024
| } | ||
|
|
||
| if (isFetched) { | ||
| addSuccessToast('List refreshed'); |
eschutho
reviewed
May 8, 2024
| name="select-catalog" | ||
| notFoundContent={t('No compatible catalog found')} | ||
| placeholder={t('Select catalog or type to search catalogs')} | ||
| onChange={item => changeCatalog(item as CatalogOption)} |
There was a problem hiding this comment.
did passing just changeCatalog to the prop fail because of a ts error? (as opposed to the arrow function)
eschutho
reviewed
May 8, 2024
| function renderSchemaSelect() { | ||
| const refreshIcon = !readOnly && ( | ||
| <RefreshLabel | ||
| onClick={() => refetch()} | ||
| onClick={() => refetchSchemas()} |
There was a problem hiding this comment.
Suggested change
| onClick={() => refetchSchemas()} | |
| onClick={refetchSchemas} |
eschutho
approved these changes
May 8, 2024
9 tasks
imancrsrk
pushed a commit
to imancrsrk/superset
that referenced
this pull request
May 10, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
May 31, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR finishes the initial work for #22862, introducing a new hierarchical data level: catalogs.
A few important concepts:
See the option at the bottom of "Advanced" -> "Other" -> "Allow changing catalogs":
Once the feature is enabled, a dropdown will show up the in
DatabaseSelectorcomponent, allowing users to select a catalog. This includes SQL Lab, the page for adding datasets, and the dataset editor.The dropdown is hidden when a database without the feature is selected:
Screen.Recording.2024-05-07.at.5.01.08.PM.mov
Nothing should change for databases that don't support catalogs, or that have it disabled. Relevant APIs have been updated to accept an optional
catalog. Databases without support will simply ignore it, and databases that support it will use it to establish the connection, or fallback to the default catalog if anullis passed.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
See above.
TESTING INSTRUCTIONS
WIP, I'm currently updating existing tests and adding new tests.
ADDITIONAL INFORMATION