fix: export/import catalogs #28408
Merged
fix: export/import catalogs #28408
+105
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
import-export-catalog-field
branch
from
a71092a to
7b17972
Compare
betodealmeida
force-pushed
the
import-export-catalog-field
branch
from
7b17972 to
15d85de
Compare
eschutho
reviewed
May 9, 2024
| @@ -1135,7 +1142,9 @@ class SqlaTable( | |||
| # The reason it does not physically exist is MySQL, PostgreSQL, etc. have a | |||
| # different interpretation of uniqueness when it comes to NULL which is problematic | |||
| # given the schema is optional. | |||
There was a problem hiding this comment.
schema and catalog are optional...
eschutho
approved these changes
May 9, 2024
imancrsrk
pushed a commit
to imancrsrk/superset
that referenced
this pull request
May 10, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
May 31, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add the
catalogfield to import/export commands, wherever relevant.I also added some tests for the uniqueness checks, that now considers catalog as well.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION