fix: utf-16 json encoder support #28486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mistercrunch
approved these changes
May 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #28486 +/- ##
===========================================
+ Coverage 60.48% 83.43% +22.94%
===========================================
Files 1931 521 -1410
Lines 76236 37429 -38807
Branches 8568 0 -8568
===========================================
- Hits 46114 31228 -14886
+ Misses 28017 6201 -21816
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Looks like tests are failing ... |
|
indeed missed one integration test and also i see now some format issues, will fix both |
|
@mistercrunch - Fixed and tested locally both formats and integration tests |
|
@mistercrunch |
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
Co-authored-by: Eyal Ezer <[email protected]>
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
May 31, 2024
Co-authored-by: Eyal Ezer <[email protected]>
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Co-authored-by: Eyal Ezer <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following the pessimistic json encoder fix and an issue reported in #28372 which fails to decode UTF-16 bytes in SQL Lab. Added UTF-16 encoding support for json serialization.