Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Dashboard): Prevent scroll when hovering filters #28550

Merged
merged 1 commit into from
May 16, 2024
Merged

fix(Dashboard): Prevent scroll when hovering filters #28550

merged 1 commit into from
May 16, 2024

Conversation

geido
Copy link
Member

@geido geido commented May 16, 2024

SUMMARY

Recent changes for accessibility have introduced an issue that was scrolling the Dashboard page at the top when hovering filters. This fixes it.

BEFORE

Sales.Dashboard.mp4

AFTER

Sales.Dashboard-fixed.mp4

TESTING INSTRUCTIONS

  1. Enter a Dashboard
  2. Apply filters
  3. Scroll to the bottom charts
  4. Hover a filter
  5. Dashboard should not scroll

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido requested a review from kgabryje May 16, 2024 11:52
@geido geido merged commit 938a727 into master May 16, 2024
33 checks passed
@rusackas rusackas deleted the geido/fix/dashboard-filter-scroll-up branch May 16, 2024 16:37
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label May 23, 2024
@michael-s-molina michael-s-molina removed the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label May 30, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@geido @EnxDev
fix(Dashboard): Prevent scroll when hovering filters (apache#28550)
9fb7f9f
eschutho pushed a commit that referenced this pull request Jun 5, 2024
@geido @sadpandajoe
fix(Dashboard): Prevent scroll when hovering filters (#28550)
506f1b1 
(cherry picked from commit 938a727)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@geido
fix(Dashboard): Prevent scroll when hovering filters (apache#28550)
ecacea0
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geido @kgabryje @mistercrunch @michael-s-molina