Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ipython from development dependencies #28703

Merged
merged 3 commits into from
May 25, 2024
Merged

Conversation

mistercrunch
Copy link
Member

Summary

removing ipython as it's simply a nice-to-have, but not required for Superset development

@dosubot dosubot bot added the install:dependencies Installation - Dependencies label May 24, 2024
@mistercrunch mistercrunch merged commit 9ac0cf7 into master May 25, 2024
30 checks passed
@mistercrunch mistercrunch deleted the rm_ipython branch May 25, 2024 08:26
Vitor-Avila pushed a commit to Vitor-Avila/superset that referenced this pull request May 28, 2024
@john-bodley
Copy link
Member

I thought development dependencies were there to help aid development. Maybe it's worth explicitly mentioning in the documentation what are viable development dependencies.

@mistercrunch
Copy link
Member Author

mistercrunch commented May 29, 2024

Yes for this particular one the "likely hood to be used" vs "dependency burden" ratio isn't great. Currently the criteria is more or less "commonly used by humans and/or CI for development workflows".

Now that we have a workflow to upgrade things (supersetbot as a pip-compile-multi-aware dependabot replacement), it seems reasonable / manageable if we wanted to bring back more segmentation/complexity under requirements/ if we wanted to.

@mistercrunch
Copy link
Member Author

One more thought it with segmentation in requirements/ we can have different level of rigor for freshness for different files. Likely I'll set up supersetbot in different ways for base.in VS development.in

EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
hainenber pushed a commit to hainenber/superset that referenced this pull request Jun 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels install:dependencies Installation - Dependencies size/M 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants