-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds the Featured Charts dashboard #28789
feat: Adds the Featured Charts dashboard #28789
Conversation
@rusackas @yousoph @kasiazjc @kgabryje Please review the viz gallery changes. Specifically, if you agree to sort the charts alphabetically. @kasiazjc While working on the viz gallery I also noticed an inconsistent spacing between charts depending on their name. I opened #28788 to discuss it and once we have a solution, we can create a follow-up PR to fix it. FYI: We need #28652 for the Histogram chart. Right now it will render with an error. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28789 +/- ##
==========================================
+ Coverage 60.48% 70.25% +9.76%
==========================================
Files 1931 1952 +21
Lines 76236 77593 +1357
Branches 8568 8756 +188
==========================================
+ Hits 46114 54514 +8400
+ Misses 28017 20948 -7069
- Partials 2105 2131 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@michael-s-molina I love the color palette. Have you considered updating the viz gallery thumbnails with your examples so it feels more coherent/consistent—upleveling the visual quality? |
That's a great suggestion! What do you think @kasiazjc @rusackas? |
superset/examples/configs/charts/Featured Charts/Graph_124.yaml
Outdated
Show resolved
Hide resolved
@john-bodley I opened #29076 to register your suggestion and added a topic for the next Town Hall. |
95d4875
to
f42a4df
Compare
e6c898e
to
a98ab9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This reverts commit 95706d9.
SUMMARY
Creates a new example dashboard called Featured Charts with the objective of demonstrating our most active supported charts. Another objective is to provide a dashboard where we can test our plugin features using these chart types.
This PR also changes the viz gallery to include missing featured charts and sort the charts alphabetically to help users find the charts they are looking for. Another small tweak was to add some margin to the Create New Chart button.
TESTING INSTRUCTIONS
Check the Featured Charts dashboard and the viz gallery changes.
ADDITIONAL INFORMATION