Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds the Featured Charts dashboard #28789

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented May 31, 2024

SUMMARY

Creates a new example dashboard called Featured Charts with the objective of demonstrating our most active supported charts. Another objective is to provide a dashboard where we can test our plugin features using these chart types.

Screenshot 2024-05-31 at 09 27 47 Screenshot 2024-05-31 at 09 28 10 Screenshot 2024-05-31 at 09 28 32 Screenshot 2024-05-31 at 09 28 57


This PR also changes the viz gallery to include missing featured charts and sort the charts alphabetically to help users find the charts they are looking for. Another small tweak was to add some margin to the Create New Chart button.

Screenshot 2024-05-31 at 10 36 49

TESTING INSTRUCTIONS

Check the Featured Charts dashboard and the viz gallery changes.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina
Copy link
Member Author

michael-s-molina commented May 31, 2024

@rusackas @yousoph @kasiazjc @kgabryje Please review the viz gallery changes. Specifically, if you agree to sort the charts alphabetically.

@kasiazjc While working on the viz gallery I also noticed an inconsistent spacing between charts depending on their name. I opened #28788 to discuss it and once we have a solution, we can create a follow-up PR to fix it.

FYI: We need #28652 for the Histogram chart. Right now it will render with an error.

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.25%. Comparing base (76d897e) to head (a98ab9f).
Report is 1094 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28789      +/-   ##
==========================================
+ Coverage   60.48%   70.25%   +9.76%     
==========================================
  Files        1931     1952      +21     
  Lines       76236    77593    +1357     
  Branches     8568     8756     +188     
==========================================
+ Hits        46114    54514    +8400     
+ Misses      28017    20948    -7069     
- Partials     2105     2131      +26     
Flag Coverage Δ
hive 48.94% <ø> (-0.23%) ⬇️
javascript 57.78% <100.00%> (+0.07%) ⬆️
mysql 77.15% <ø> (?)
postgres 77.29% <ø> (?)
presto 53.53% <ø> (-0.27%) ⬇️
python 83.61% <ø> (+20.12%) ⬆️
sqlite 76.73% <ø> (?)
unit 59.01% <ø> (+1.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley
Copy link
Member

@michael-s-molina I love the color palette. Have you considered updating the viz gallery thumbnails with your examples so it feels more coherent/consistent—upleveling the visual quality?

@michael-s-molina
Copy link
Member Author

@michael-s-molina I love the color palette. Have you considered updating the viz gallery thumbnails with your examples so it feels more coherent/consistent—upleveling the visual quality?

That's a great suggestion! What do you think @kasiazjc @rusackas?

@geido geido self-requested a review May 31, 2024 16:06
@michael-s-molina
Copy link
Member Author

@michael-s-molina I love the color palette. Have you considered updating the viz gallery thumbnails with your examples so it feels more coherent/consistent—upleveling the visual quality?

@john-bodley I opened #29076 to register your suggestion and added a topic for the next Town Hall.

@michael-s-molina michael-s-molina force-pushed the add-featured-charts-dashboard branch from 95d4875 to f42a4df Compare June 4, 2024 13:14
@michael-s-molina michael-s-molina force-pushed the add-featured-charts-dashboard branch from e6c898e to a98ab9f Compare June 4, 2024 13:52
@michael-s-molina michael-s-molina marked this pull request as ready for review June 4, 2024 13:53
@dosubot dosubot bot added dashboard:sample Related to sample dashboards viz:charts Namespace | Anything related to viz types labels Jun 4, 2024
@michael-s-molina michael-s-molina requested a review from rusackas June 4, 2024 18:03
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit 95706d9 into apache:master Jun 4, 2024
40 of 59 checks passed
sadpandajoe added a commit to preset-io/superset that referenced this pull request Jul 29, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:sample Related to sample dashboards plugins size/XXL viz:charts Namespace | Anything related to viz types 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants