Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CI errors as the result of removing React imports #29089

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix: CI errors as the result of removing React imports #29089

merged 1 commit into from
Jun 5, 2024

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Follow up of #28571 to fix CI errors.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the viz:charts:histogram Related to the Histogram chart label Jun 5, 2024
@michael-s-molina michael-s-molina changed the title fix: CI errors as the result of removing React import fix: CI errors as the result of removing React imports Jun 5, 2024
@michael-s-molina michael-s-molina merged commit a9cebe8 into apache:master Jun 5, 2024
34 of 35 checks passed
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@michael-s-molina @eschutho
fix: CI errors as the result of removing React imports (#29089)
125d4d8
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@michael-s-molina
fix: CI errors as the result of removing React imports (apache#29089)
ba22a87
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

@dpgaspar dpgaspar Awaiting requested review from dpgaspar

@geido geido Awaiting requested review from geido

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels plugins size/XS viz:charts:histogram Related to the Histogram chart 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @kgabryje @mistercrunch