Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: s/MockFixture/MockerFixture/g #29160

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

We use both MockFixture and MockerFixture for the type of the mocker fixture. Both work, but if you inspect the fixture you'll see that is has type pytest_mock.plugin.MockerFixture.

This PR standardizes the type to MockerFixture.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Sorry, something went wrong.

@betodealmeida betodealmeida added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Jun 10, 2024
@betodealmeida betodealmeida merged commit 8e15d48 into master Jun 10, 2024
34 checks passed
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@rusackas rusackas deleted the standardize-mockerfixture branch September 27, 2024 21:05
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels merge-if-green If approved and tests are green, please go ahead and merge it for me size/L 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants