feat(trino): Add functionality to upload data #29164
Merged
+211
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29164 +/- ##
===========================================
+ Coverage 60.48% 83.73% +23.24%
===========================================
Files 1931 518 -1413
Lines 76236 37547 -38689
Branches 8568 0 -8568
===========================================
- Hits 46114 31441 -14673
+ Misses 28017 6106 -21911
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
john-bodley
force-pushed
the
john-bodley--presto-df-to-sql
branch
from
2680b22 to
97d011d
Compare
dosubot
bot
added
data:connect:trino
john-bodley
commented
Jun 10, 2024
| @@ -132,6 +132,7 @@ gevent = ["gevent>=23.9.1"] | |||
| gsheets = ["shillelagh[gsheetsapi]>=1.2.18, <2"] | |||
| hana = ["hdbcli==2.4.162", "sqlalchemy_hana==0.4.0"] | |||
| hive = [ | |||
| "boto3", | |||
There was a problem hiding this comment.
This is imported within the HiveEngineSpec and thus likely should be defined as a depedency.
| @@ -154,7 +155,7 @@ pinot = ["pinotdb>=0.3.3, <0.4"] | |||
| playwright = ["playwright>=1.37.0, <2"] | |||
| postgres = ["psycopg2-binary==2.9.6"] | |||
| presto = ["pyhive[presto]>=0.6.5"] | |||
| trino = ["trino>=0.328.0"] | |||
| trino = ["boto3", "trino>=0.328.0"] | |||
| @@ -79,6 +79,12 @@ def upload_to_s3(filename: str, upload_prefix: str, table: Table) -> str: | |||
| ) | |||
|
|
|||
| s3 = boto3.client("s3") | |||
|
|
|||
| # The location is merely an S3 prefix and thus we first need to ensure that there is | |||
There was a problem hiding this comment.
I discovered this issue when testing locally, i.e., given that the location field is a directory as opposed to a file any file within said directory is slurped into the table, hence why we should first ensure that the location is empty.
michael-s-molina
approved these changes
Jun 11, 2024
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
9 tasks
michael-s-molina
added a commit
to michael-s-molina/superset
that referenced
this pull request
Nov 25, 2024
This reverts commit 53798c7.
michael-s-molina
added a commit
that referenced
this pull request
Nov 25, 2024
michael-s-molina
added a commit
that referenced
this pull request
Nov 25, 2024
mistercrunch
added
🏷️ bot
sadpandajoe
pushed a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adds functionality to allow Trino to upload data via a CSV which previously resided as custom logic at Airbnb. This is based on the logic outlined in the
HiveEngineSpec.Note I'm not certain whether this is best housed in the
TrinoEngineSpecorPrestoBaseEngineSpec. Airbnb currently only supports Trino and thus I wouldn't be able to provide end-to-end testing for Presto.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Added tests—mimicking the Hive logic.
ADDITIONAL INFORMATION