test(storybook): fix component stories #29245
Conversation
msyavuz
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Fantastic, thanks for digging in here! I'll pull/test as soon as I'm able. |
| @@ -87,6 +87,7 @@ InteractiveAlert.args = { | |||
| InteractiveAlert.argTypes = { | |||
| onClose: { action: 'onClose' }, | |||
| type: { | |||
| control: { type: 'select', options: types }, | |||
| control: { type: 'select' }, | |||
| options: types, | |||
There was a problem hiding this comment.
This one doesn't seem to be working still.
There was a problem hiding this comment.
This one modifies the "type" control, i think it should be working.
superset-frontend/src/components/AsyncAceEditor/AsyncAceEditor.stories.tsx
Show resolved
Hide resolved
superset-frontend/src/components/AsyncAceEditor/AsyncAceEditor.stories.tsx
Show resolved
Hide resolved
| @@ -59,7 +59,8 @@ InteractiveDropdownButton.args = { | |||
| InteractiveDropdownButton.argTypes = { | |||
| placement: { | |||
| defaultValue: 'top', | |||
| control: { type: 'select', options: PLACEMENTS }, | |||
| control: { type: 'select' }, | |||
| options: PLACEMENTS, | |||
There was a problem hiding this comment.
Probably works great, but this thing totally crashes, as it expects to receive only a single child element.
There was a problem hiding this comment.
I don't see any changes but no crashes either, weird.
| }, | ||
| optionType: { | ||
| defaultValue: 'default', | ||
| control: { type: 'radio', options: ['default', 'button'] }, | ||
| control: { type: 'radio' }, | ||
| options: ['default', 'button'], |
There was a problem hiding this comment.
THese controls LOOK fine, but the story bombs out with an error of
"Cannot read properties of undefined (reading 'find')"
Note that I know none of this is your fault. We kind of forced the Storybook upgrade through, and it had a lot of unexpected fallout like this.
|
Thank you for the review and kind words. If we can merge this it would be great, if the problems are with stories and not component themselves i can open specific PR's for that. For now i think having working controls in storybook improves its usefullness. |
mistercrunch
added
🏷️ bot
test(storybook): Fix component story controls
SUMMARY
Storybook controls for some components were not working. This pr aims to fix that.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION