Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filters not updating with force update when caching is enabled #29291

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix: filters not updating with force update when caching is enabled #29291

merged 1 commit into from
Jun 18, 2024

Conversation

ka-weihe
Copy link
Contributor

@ka-weihe ka-weihe commented Jun 18, 2024 •
edited
Loading

SUMMARY

Currently, when you have caching enabled and you click "refresh dashboard" it only updates the charts but not the filters. This is despite the filters having a loading spinner next to them.

TESTING INSTRUCTIONS

  1. Setup Superset with caching
  2. Create a dataset with a simple table and create any chart and add it to a dashboard. Add a filter to the dashboard - could be the values of one of the columns. Insert a new row to the table with a new value for the column you have created a filter for.
  3. Force refresh the dashboard using "refresh dashboard" in the upper right hand corner.

You will see your chart updating, but not the filter.

ADDITIONAL INFORMATION

@dosubot dosubot bot added dashboard:native-filters Related to the native filters of the Dashboard dashboard:refresh Related to the refresh frequency of the Dashboard labels Jun 18, 2024
@ka-weihe ka-weihe mentioned this pull request Jun 18, 2024
Closed
github-actions[bot]
github-actions bot reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@michael-s-molina michael-s-molina linked an issue Jun 18, 2024 that may be closed by this pull request
bug: Filters are not updating with force update if cache is enabled for some time #25893
Closed
michael-s-molina
michael-s-molina approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @ka-weihe!

villebro
villebro approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, really great improvement!

@michael-s-molina michael-s-molina merged commit 527f1d2 into apache:master Jun 18, 2024
37 of 38 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jun 18, 2024
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Jun 18, 2024
@Vitor-Avila
Copy link
Contributor

This is awesome! thank you 🙏

@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Jun 20, 2024
michael-s-molina pushed a commit that referenced this pull request Jun 26, 2024
@ka-weihe @michael-s-molina
fix: filters not updating with force update when caching is enabled (#…
efab0dd 
…29291)

(cherry picked from commit 527f1d2)
@mistercrunch mistercrunch added 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@ka-weihe @eschutho
fix: filters not updating with force update when caching is enabled (#…
238261e 
…29291)
@dosubot dosubot bot mentioned this pull request Sep 19, 2024
Open
3 tasks
@dosubot dosubot bot mentioned this pull request Oct 24, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard dashboard:refresh Related to the refresh frequency of the Dashboard size/XS v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.2 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Filters are not updating with force update if cache is enabled for some time
6 participants
@ka-weihe @Vitor-Avila @villebro @michael-s-molina @mistercrunch @john-bodley