chore(distributed-lock): refactor tests

[villebro]

SUMMARY

This PR refactors the distributed lock tests in the following way:

1. Replace assertions of mocked internals with assertions of the functional aspects of the lock
2. Assert that the lock state is committed to the metastore during the locking process

This will make it safer to refactor SQLAlchemy session logic in accordance with SIP-99A, as the test will ensure that commits happen at the critical moments (lock is taken, lock is released). In addition, it makes the test immune to refactoring of internals of the lock.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.73%. Comparing base (76d897e) to head (836012e).
Report is 1094 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #29302       +/-   ##
===========================================
+ Coverage   60.48%   83.73%   +23.24%     
===========================================
  Files        1931      518     -1413     
  Lines       76236    37552    -38684     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31443    -14671     
+ Misses      28017     6109    -21908     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	48.94% <42.85%> (-0.23%)	⬇️
javascript	?
mysql	77.20% <71.42%> (?)
postgres	77.33% <71.42%> (?)
presto	53.55% <42.85%> (-0.25%)	⬇️
python	83.73% <100.00%> (+20.24%)	⬆️
sqlite	76.79% <71.42%> (?)
unit	59.25% <85.71%> (+1.63%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[michael-s-molina]

Nice!