chore(Home): Avoid firing API requests when a custom Home is used #29493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
approved these changes
Jul 5, 2024
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
github-actions
bot
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
It's possible to override the content for the Homepage through the
extensionRegistry(available options includewelcome.banner,welcome.main.replacementandwelcome.message).Currently, regardless if a custom Homepage is set the React hook responsible for fetching the data is always called, resulting in additional/un-necessary API calls for Organizations with a custom home component implemented.
This PR avoids the data fetching process in case a custom Home is defined (through
welcome.main.replacement).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No UI changes.
TESTING INSTRUCTIONS
Added test.
ADDITIONAL INFORMATION