Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataset import): Support catalog field during dataset import #29576

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Vitor-Avila
Copy link
Contributor

SUMMARY

Support for catalogs have been recently added to Superset. The field is now included in the dataset metadata (including the exported YAML). This PR adds the catalog field to the import schema (logic to handle the catalog during import was already there).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No UI changes.

TESTING INSTRUCTIONS

Added the catalog field to the mock dataset. Manual test would require:

  1. Create a dataset. Make sure the catalog field is added to the metadata.
  2. Export the dataset.
  3. Import it.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the data:dataset Related to dataset configurations label Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.69%. Comparing base (76d897e) to head (dc064c7).
Report is 966 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29576       +/-   ##
===========================================
+ Coverage   60.48%   83.69%   +23.20%     
===========================================
  Files        1931      524     -1407     
  Lines       76236    37772    -38464     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31612    -14502     
+ Misses      28017     6160    -21857     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.13% <100.00%> (-0.04%) ⬇️
javascript ?
mysql 76.99% <100.00%> (?)
postgres 77.09% <100.00%> (?)
presto 53.71% <100.00%> (-0.10%) ⬇️
python 83.69% <100.00%> (+20.20%) ⬆️
sqlite 76.58% <100.00%> (?)
unit 59.74% <100.00%> (+2.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vitor-Avila Vitor-Avila merged commit 0d352b4 into apache:master Jul 12, 2024
39 of 40 checks passed
@github-actions github-actions bot added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels data:dataset Related to dataset configurations size/XS 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants