refactor: Remove dead code from the Word Cloud plugin #29594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
frontend:refactor
michael-s-molina
force-pushed
the
remove-word-cloud-dead-code
branch
from
e4671ac to
97a6217
Compare
michael-s-molina
force-pushed
the
remove-word-cloud-dead-code
branch
from
97a6217 to
84b2188
Compare
|
/testenv up |
| export default function transformProps(chartProps: ChartProps): WordCloudProps { | ||
| const { width, height, formData, queriesData } = chartProps; | ||
| const { encoding, rotation, sliceId, colorScheme } = | ||
| formData as WordCloudFormData; | ||
| const { |
There was a problem hiding this comment.
The index file of the plugin was referencing the legacy transformProps function. I just copied the code from there here and deleted that file.
|
@michael-s-molina Ephemeral environment spinning up at http://34.211.94.59:8080. Credentials are |
rusackas
approved these changes
Jul 17, 2024
|
Ephemeral environment shutdown and build artifacts deleted. |
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
|
@supersetbot label 4.1 |
github-actions
bot
added
the
v4.1
sadpandajoe
pushed a commit
that referenced
this pull request
Aug 13, 2024
(cherry picked from commit 85b6694)
github-actions
bot
added
🍒 4.1.0
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The Word Cloud plugin had a legacy version which was not being used anymore. This PR removes that dead code including the associated tests.
TESTING INSTRUCTIONS
CI should be sufficient.
ADDITIONAL INFORMATION