-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): missing column autocomplete in custom SQL #29672
fix(explore): missing column autocomplete in custom SQL #29672
Conversation
<> | ||
<Global | ||
styles={css` | ||
.ace_tooltip { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinpark I noticed that src/SqlLab/components/AceEditorWrapper/index.tsx
has similar logic as this code. Is it possible to avoid code duplication in this case and also ensure similar behavior for both editors by using a single component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @michael-s-molina and I discussed offline, the SqlLab/AceEditorWrapper component has styles associated with the SqlLab Editor, and this section applies the global ace-editor styles.
522707d
to
da1f147
Compare
@supersetbot label 4.1 |
(cherry picked from commit 3c97145)
@supersetbot unlabel 4.1 |
@sadpandajoe Is there a reason why this was excluded from version 4.1? Could you include this commit in 4.1? |
Yeah i can grab it |
(cherry picked from commit 3c97145)
SUMMARY
The
keywords
field was missing in the Custom SQL editor of the column item, causing the autocomplete feature in the metrics field to be unavailable.This commit fills in the missing keywords field in the Column component and adds styling to the tooltip section of the autocomplete feature.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--column-autocomplete.mov
After:
after--column-keywords.mov
TESTING INSTRUCTIONS
Open a column selector in explore
Click Custom SQL and type a column name
ADDITIONAL INFORMATION