fix: Downgrade of revision 678eefb4ab44 throws error

[michael-s-molina]

SUMMARY

Fixes the following error when downgrading revision 678eefb4ab44:

sqlalchemy.exc.OperationalError: (MySQLdb.OperationalError) 
(1553, "Cannot drop index 'idx_user_id_database_id': needed in a foreign key constraint")

Fixes #29789

TESTING INSTRUCTIONS

Make sure you can downgrade the revision.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.70%. Comparing base (76d897e) to head (2553857).
Report is 1094 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/migrations/shared/constraints.py	0.00%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #29799       +/-   ##
===========================================
+ Coverage   60.48%   83.70%   +23.21%     
===========================================
  Files        1931      527     -1404     
  Lines       76236    38012    -38224     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31819    -14295     
+ Misses      28017     6193    -21824     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	49.04% <0.00%> (-0.12%)	⬇️
javascript	?
mysql	76.82% <0.00%> (?)
postgres	76.89% <0.00%> (?)
presto	53.59% <0.00%> (-0.21%)	⬇️
python	83.70% <0.00%> (+20.21%)	⬆️
sqlite	76.38% <0.00%> (?)
unit	59.95% <0.00%> (+2.32%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mistercrunch]

LGTM - though it could be nice to implement as a reusable function def drop_fks_for_table(table_name) in superset/migrations/shared/constraints.py

[michael-s-molina]

LGTM - though it could be nice to implement as a reusable function def drop_fks_for_table(table_name) in superset/migrations/shared/constraints.py

Good point. Done 👍🏼

[sadpandajoe]

@supersetbot label 4.1