Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Implement Echarts treeshaking #29874

Merged
merged 4 commits into from
Aug 7, 2024
Merged

perf: Implement Echarts treeshaking #29874

merged 4 commits into from
Aug 7, 2024

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Aug 6, 2024

SUMMARY

Use Echarts tree shaking API to shrink the library's bundle size.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screenshot 2024-08-06 at 14 08 29

After:

Screenshot 2024-08-06 at 15 59 04

TESTING INSTRUCTIONS

All Echarts and all features (like legends, data zoom etc) should work as before.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend viz:charts:echarts Related to Echarts labels Aug 6, 2024
@kgabryje kgabryje force-pushed the perf/echarts-treeshaking branch from 27b1036 to 03cb2c8 Compare August 6, 2024 15:40
villebro
villebro approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice work, improvements on many levels here! One final thing that comes to mind is maybe adding a linting rule to block direct imports of echarts. Other than that LGTM!

@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Aug 6, 2024
@rusackas
Copy link
Member

rusackas commented Aug 6, 2024

@michael-s-molina
Copy link
Member

KAMIL IS ON FIRE!!! 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥

@kgabryje
Copy link
Member Author

kgabryje commented Aug 6, 2024

Super nice work, improvements on many levels here! One final thing that comes to mind is maybe adding a linting rule to block direct imports of echarts. Other than that LGTM!

Good idea! Let me do that in a separate PR 🙂

@kgabryje kgabryje closed this Aug 6, 2024
@kgabryje kgabryje reopened this Aug 6, 2024
@kgabryje kgabryje merged commit c220245 into apache:master Aug 7, 2024
70 checks passed
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Aug 7, 2024
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 23, 2024
sadpandajoe pushed a commit that referenced this pull request Sep 23, 2024
@kgabryje @sadpandajoe
perf: Implement Echarts treeshaking (#29874)
fed8674 
(cherry picked from commit c220245)
sadpandajoe pushed a commit that referenced this pull request Oct 15, 2024
@kgabryje @sadpandajoe
perf: Implement Echarts treeshaking (#29874)
2a98780 
(cherry picked from commit c220245)
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
@kgabryje @nyohasstium
perf: Implement Echarts treeshaking (apache#29874)
abb7c86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@Antonio-RiveroMartnez Antonio-RiveroMartnez Awaiting requested review from Antonio-RiveroMartnez

@geido geido Awaiting requested review from geido

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend plugins size/L v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch viz:charts:echarts Related to Echarts 🍒 4.1.0 🍒 4.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kgabryje @rusackas @michael-s-molina @villebro @mistercrunch @sadpandajoe