Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Security manager incorrect calls #29884

Merged

Fixes formatting

02bff33
Select commit
Loading
Failed to load commit list.
Merged

fix: Security manager incorrect calls #29884

Fixes formatting
02bff33
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 20, 2024 in 0s

83.64% (+23.15%) compared to 76d897e

View this Pull Request on Codecov

83.64% (+23.15%) compared to 76d897e

Details

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.64%. Comparing base (76d897e) to head (02bff33).
Report is 603 commits behind head on master.

Files Patch % Lines
superset/connectors/sqla/models.py 81.48% 5 Missing ⚠️
superset/models/helpers.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29884       +/-   ##
===========================================
+ Coverage   60.48%   83.64%   +23.15%     
===========================================
  Files        1931      528     -1403     
  Lines       76236    38155    -38081     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31914    -14200     
+ Misses      28017     6241    -21776     
+ Partials     2105        0     -2105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.