Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only show dataset name in list #29944

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

eschutho
Copy link
Member

SUMMARY

Shows just the dataset name, as with the schema it tends to be too long. I moved the full schema/dataset name into the tooltip. The link remains the same.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2024-08-14.at.3.26.12.PM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho changed the title only show dataset name in list fix: only show dataset name in list Aug 15, 2024
@eschutho eschutho force-pushed the elizabeth/fix-dataset-name branch from 5748c92 to af6cd00 Compare August 15, 2024 00:05
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Doesn't seem like a breaking change since the info is still available.

@eschutho eschutho merged commit 88d07ce into master Aug 15, 2024
34 checks passed
@michael-s-molina
Copy link
Member

It may be misleading to not show the schema alongside the dataset name given that many datasets have the same name. I understand that users can still view this information in the tooltip, but I don't think it's sufficient. It also kind of force the user to hover the name to see if it's actually the dataset from a particular schema. Maybe add a column for schema?

@michael-s-molina
Copy link
Member

There's no schema filter either. Maybe it would be good to add one, specially if we have a schema column.

@rusackas rusackas deleted the elizabeth/fix-dataset-name branch September 27, 2024 20:54
nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
betodealmeida pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants