fix(sqllab): flaky json explore modal due to shallow equality checks for extra data #29978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
global:async-query
michael-s-molina
approved these changes
Aug 21, 2024
michael-s-molina
added
the
v4.0
| @@ -696,7 +698,19 @@ export default function sqlLabReducer(state = {}, action) { | |||
| ? prevState | |||
| : currentState, | |||
| }; | |||
| change = true; | |||
| const newExtra = JSON.stringify(newQueries[id].extra); | |||
There was a problem hiding this comment.
You can use Lodash's isEqual here.
michael-s-molina
added
the
v4.1
github-actions
bot
added
🍒 4.1.0
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In the async query, the
extrafield of the pulling data is in object form, and when the result is completed, it fails to verify equality due to shallow equality checks.This caused unnecessary over-rendering of the result panel, so this commit resolved the issue by comparing the extra field separately.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--flaky-json-modal.mov
After:
after--flaky-json-modal.mov
TESTING INSTRUCTIONS
Run a large query in a new tab, then switch to another tab.
Run a quick query that includes a JSON value, then click the value to verify that the JSON modal is shown steadily.
ADDITIONAL INFORMATION