-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use StrEnum type for GuestTokenResourceType to fix token parsing #30042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! However, there's already a similar class, so please reuse that one
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30042 +/- ##
===========================================
+ Coverage 60.48% 83.68% +23.20%
===========================================
Files 1931 528 -1403
Lines 76236 38207 -38029
Branches 8568 0 -8568
===========================================
- Hits 46114 31975 -14139
+ Misses 28017 6232 -21785
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The cypress check seems stubbornly flaky - I'll keep restarting it until it goes green (I can't imagine this change could have broken any of the cypress tests..) |
Thanks for the fix @hao-zhuventures |
This has now been restarted 11 times, I'm starting to think there's something weird going on.. |
Omg finally 😆 |
SUMMARY
This change is to fix the "incorrect" check results from comparing the
guest_token
claims with the enum value. By changing the type to beStrEnum
, the str based comparison will output the desired results.Additional context: guest user jwt token claims are casted to the
GuestToken
type here.TESTING INSTRUCTIONS
Manual check before / after
and CI checks.
ADDITIONAL INFORMATION